> On März 9, 2016, 6:19 nachm., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 325 > > <https://git.reviewboard.kde.org/r/127318/diff/1/?file=448592#file448592line325> > > > > About me, since i made this patch, when notification is closed lambda > > above is called with transient = true => > > line 305, 306 as same as below lines. > > Kai Uwe Broulik wrote: > I have no idea what you are talking about > > Anthony Fieroni wrote: > I mean *else* branch is *nonsence*. You trying to remove applet twice if > notification present, witch is KNotification::Persistent. *Must* works > without this patch.
I still don't get it. It does not work without this patch which is why I wrote it. Without this patch the applet is only removed when I explicitly close the notification, not when I let the 60s timer run out... - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127318/#review93354 ----------------------------------------------------------- On März 9, 2016, 5:48 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127318/ > ----------------------------------------------------------- > > (Updated März 9, 2016, 5:48 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > When the undo timer fires the undo notification is removed but the applet > isn't actually removed and re-appears after you restart plasma. > > > Diffs > ----- > > src/plasma/private/applet_p.cpp 14b1deb > > Diff: https://git.reviewboard.kde.org/r/127318/diff/ > > > Testing > ------- > > Removed applet, pressed X on notification, restarted plasma -> applet > permanently gone > Removed applet, pressed "Undo" -> applet re-appeared > Removed applet, waited 60s, restarted plasma -> applet permanently gone > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
