----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/#review93360 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On March 5, 2016, 6:48 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127285/ > ----------------------------------------------------------- > > (Updated March 5, 2016, 6:48 a.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-workspace > > > Description > ------- > > Not sure if this is an intented upstream change (I reported it anyway > https://bugreports.qt.io/browse/QTBUG-51683 ), but QDBusServiceWatcher can't > watch all service anymore in Qt 5.6 RC with empty service name string. > > Let's simple use the "deprecated" > QDBusConnectionInterface::serviceOwnerChanged signal to do this work, which > is also used by qdbusviewer. > > Change mpris2 dataengine and systemtray to use > QDBusConnectionInterface::serviceOwnerChanged. > > > Diffs > ----- > > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h 9e59501 > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 94c3efc > dataengines/mpris2/mpris2engine.cpp 064ca60 > > Diff: https://git.reviewboard.kde.org/r/127285/diff/ > > > Testing > ------- > > mpris2 dataengine and mediacontroller now back to work with qt 5.6. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
