----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93457 -----------------------------------------------------------
Fix it, then Ship it! shell/CMakeLists.txt (line 42) <https://git.reviewboard.kde.org/r/127346/#comment63713> different commit shell/shellmanager.h (line 48) <https://git.reviewboard.kde.org/r/127346/#comment63714> s_testModeLayout shell/testcorona.h (line 25) <https://git.reviewboard.kde.org/r/127346/#comment63715> in the other case FooCorona is used as a convention for subclasses, CoronaTest would make it more obvious this is not a corona subclass - Marco Martin On March 12, 2016, 3:59 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 3:59 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > ----- > > applets/analog-clock/contents/tests/test.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellcorona.cpp 54667da > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/testLayout.js.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel