graesslin added a comment.
Implementation of the protocol looks good, but please see my comment on whether the interface has a correct semantic. I fear it cannot properly handle the case that the compositor produces several buffers before the client consumed them. Please also add an auto test for the code, we try to have a complete test coverage for KWayland. INLINE COMMENTS src/client/protocols/remoteaccess.xml:21 In Wayland it's common to use underscore names instead of camel case. Thus it would be buffer_no_longer_needed. Do we need the request at all or can we just use a deconstructor? Btw. I'm wondering how would the mapping between a buffer ready and a buffer no longer needed be done. It's possible that the producer provides more buffers than the consumer can consume. Maybe we need a dedicated remote-buffer interface for each one? REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Kanedias, graesslin Cc: plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
