----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127696/#review94733 -----------------------------------------------------------
Fix it, then Ship it! Some minor stuff inline. If the artists are happy with the semantics, go for it. src/declarativeimports/core/colorscope.h (line 68) <https://git.reviewboard.kde.org/r/127696/#comment64369> What does positive mean exactly in this context? @since 5.22? (also for following properties) src/declarativeimports/core/colorscope.h (line 73) <https://git.reviewboard.kde.org/r/127696/#comment64370> neutral? (perhaps also explain "neutral"'s meaning. src/declarativeimports/core/colorscope.h (line 80) <https://git.reviewboard.kde.org/r/127696/#comment64371> positive -> negative, also please explain src/declarativeimports/core/colorscope.cpp (line 189) <https://git.reviewboard.kde.org/r/127696/#comment64372> double empty line src/declarativeimports/core/colorscope.cpp (line 202) <https://git.reviewboard.kde.org/r/127696/#comment64373> double empty line src/declarativeimports/core/colorscope.cpp (line 213) <https://git.reviewboard.kde.org/r/127696/#comment64374> double empty line - Sebastian Kügler On April 20, 2016, 12:49 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127696/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 12:49 p.m.) > > > Review request for Plasma and Andreas Kainz. > > > Repository: plasma-framework > > > Description > ------- > > add named colors for positive (usually green) > neutral(usually yellow) negative(usually red) > foreground objects, such as text or parts of > svg icons/themes > > > Diffs > ----- > > autotests/data/plasma/desktoptheme/testtheme/colors e242dbb > autotests/themetest.cpp 3992246 > src/declarativeimports/core/colorscope.h b0f0ada > src/declarativeimports/core/colorscope.cpp 5f7363b > src/declarativeimports/core/quicktheme.h f1af4ca > src/declarativeimports/core/quicktheme.cpp 3411b3d > src/plasma/private/theme_p.cpp 1aaf021 > src/plasma/theme.h 271328c > > Diff: https://git.reviewboard.kde.org/r/127696/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
