apol added inline comments. INLINE COMMENTS
> xrandroutput.cpp:258 > > - Q_FOREACH(const QString &pre, embedded) { > + for (const QLatin1String &pre : embedded) { > if (name.toUpper().startsWith(pre)) { This one is fine, but I wouldn't change from `foreach -> for` as a norm, as it can easily backfire. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1866 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: apol, broulik, graesslin, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel