davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > shutdowndlg.cpp:182 > > - show(); > + connect(this, &QWindow::screenChanged, this, > + [this] (QScreen *screen) { What are you trying to do here? (because I'm pretty sure this isn't going to do what you want, and you've got a possibility to infinite loop) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2264 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel