----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/#review98311 -----------------------------------------------------------
>Unfortunately I couldn't figure out a way to tell whether we're a QQC Button >(like the widgets logic) does, so we now get a faint blue line (hard to tell >with default colorscheme) at the bottom of QQC push buttons :( option->styleObject && option->styleObject->property("elementType") == QLatin1String("button") - David Edmundson On Aug. 11, 2016, 11:25 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128654/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 11:25 a.m.) > > > Review request for Plasma, David Rosca and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > This enables painting the focus underline also for QtQuick Controls and fixes > an off-by-one error which caused the line to be rendered outside the QtQuick > Controls canvas and was thus invisible. > > > Diffs > ----- > > kstyle/breezestyle.cpp 12a2f35 > > Diff: https://git.reviewboard.kde.org/r/128654/diff/ > > > Testing > ------- > > Unfortunately I couldn't figure out a way to tell whether we're a QQC Button > (like the widgets logic) does, so we now get a faint blue line (hard to tell > with default colorscheme) at the bottom of QQC push buttons :( > > > File Attachments > ---------------- > > Focus underline > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png > Spurious focus underline in Honeycomb > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png > > > Thanks, > > Kai Uwe Broulik > >