ochurlaud created this revision. ochurlaud added reviewers: Plasma, mart, andreask, VDG. ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY As discussed with the VDG, the color KCM had to be split in a very simple KCM to choose a color scheme, and a color scheme editor. What is here? ------------- - I rewrote/refactor almost all the code so that it's easier to understand (hopefully). - I created a standalone app to edit. Here are the current issues: ---------------------------- 1. I reuse the headers/cpp files of the standalone app in the kcm. It would be better to directly call the app, but then I don't know how to repopulate the list when I'm done with the app (see in KColorCm::on_schemeEditButton_clicked) 2. The standalone app has not a correct name (How should I call the executable and the app?) 3. The standalone app doesn't have all the KAboutData + CommandParser things, because I'm a little lazy. To test directly, you can use the branch `andreas/kcm_update` REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 AFFECTED FILES kcms/colors/CMakeLists.txt kcms/colors/colorscm.cpp kcms/colors/colorscm.h kcms/colors/colorsettings.ui kcms/colors/schemeeditor.cpp kcms/colors/scmeditorcolors.cpp kcms/colors/scmeditorcolors.h kcms/colors/scmeditorcolors.ui kcms/colors/scmeditordialog.cpp kcms/colors/scmeditordialog.h kcms/colors/scmeditordialog.ui kcms/colors/scmeditoreffects.cpp kcms/colors/scmeditoreffects.h kcms/colors/scmeditoreffects.ui kcms/colors/scmeditoroptions.cpp kcms/colors/scmeditoroptions.h kcms/colors/scmeditoroptions.ui EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, mart, andreask, #vdg Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
