hein added inline comments.

INLINE COMMENTS

> broulik wrote in Task.qml:390
> Should we perhaps keep the Loader for optimizing the icon-tasks case, or does 
> that introduce too much overhead/code maintenance?

I think it's a wash. If we add the Loader, we have an extra QObject, an extra 
QML file, it adds instanciation latency and needs more disk I/O and parsing 
work. An invisible label isn't that heavy I think :).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2418

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to