broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rKSCREENLOCKER KScreenLocker. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When setting the view geometries, the code tries to ensure the wallpaper is loaded at the correct size already by completing initialization of the view with correct arguments. This codepath is never executed, however, as the property contains the rootObject instead of the actually expected QmlObjectSharedEngine. Moreover, accessing rootObject() while will force completion right away. This patch fixes the flickering of the wallpaper plugin which reloads the image because its source size changed. TEST PLAN Locked my screen, no more flickering one second after the lockscreen showed up. Still flickers in test mode as it first sets the size the view geometry (which equals the screen) but then only does a "show" in this case and so the window is maximized and the resulting anchors.fill changes the size of the wallpaper again. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2557 AFFECTED FILES greeter/greeterapp.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
