----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review98667 -----------------------------------------------------------
kstyle/breezestyleplugin.cpp (line 44) <https://git.reviewboard.kde.org/r/128760/#comment66461> This must be not (!inited). However this is not proper fix. Correct and test patch in this way QPointer<Qstyle> style = new Style; Below unchanged, so when QPointer got delete it hold nullptr by itself and delete will be safe. - Anthony Fieroni On Авг. 26, 2016, 12:56 преди обяд, Peter Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128760/ > ----------------------------------------------------------- > > (Updated Авг. 26, 2016, 12:56 преди обяд) > > > Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da > Costa. > > > Bugs: 356940 > https://bugs.kde.org/show_bug.cgi?id=356940 > > > Repository: breeze > > > Description > ------- > > Do not delete all style instances which we create, restrict ourselves to > the first instance. I have no idea if the delete hack is still needed, > but let's keep it until it is certain that it is unneeded. > > > Diffs > ----- > > kstyle/breezestyleplugin.cpp 083100e > > Diff: https://git.reviewboard.kde.org/r/128760/diff/ > > > Testing > ------- > > Used "Testcase (with ASAN)" from bug > https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. > Double-checked with a breakpoint on Breeze::StylePlugin::create that the > second instance is called through QProxyStyle. > > > Thanks, > > Peter Wu > >