> On Aug. 30, 2016, 10:57 nachm., Eike Hein wrote: > > Tech-wise I have no objections, the SVG looks clean. > > > > Design-wise I'm conflicted. Unlike the old implementation of the lines, > > this time no attempt was made to vert-center the content in the remaining > > negative space. This avoids old problems, but on the other hand of course > > means you get unbalanced margins; the lines eat into the button. With > > fully-filled icons that don't have padding, that means the line can be very > > close to the icon. Hmm. But I trust the VDG did the math on the pro/con > > here. > > Eike Hein wrote: > Actually, while I won't withdraw the Ship it!, I have to say the more I > use it, the more I dislike the unbalanced margins. It feels like the icon and > text are hanging from the top line like a sign from a ceiling, with a lot of > empty space below it. If the text label is additionally a short one, it feels > like someone took the content and dragged it up-left. It just feels > unharmonious and unfinished somehow. I like the appearance otherwise (I > always liked the line idea, and I like the filled backgorunds in the new > version), but I worry this is another case of us going with something that > somehow feels half-done. > > Andreas, to what degree is this design shaped by the restrictions of the > theming system? If you had complete control, would this look different > somehow? > > Andreas Kainz wrote: > andreas k: > Dear plasma and vdg, please test the tasks.svgz file as much as possible > cause improvements are always welcome and i will ship it only when i get a > ship it from plasma and vdg. I will work on the improvements as long as > needed. When i get the two ship it before saterday it will released with 5.26 > and with plasma 5.8. If the ship it get later no problem.
Eike I understand what you mean. on top panel it work really really well, but on bottom panel the margins didn't fit well. So for top panel I would leave it as it is but for bottom panel I have to think about a better solution. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98803 ----------------------------------------------------------- On Aug. 30, 2016, 3:54 nachm., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128802/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:54 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Update of the tasks.svgz file > > focus task > ---------- > had now a 3px height line in Highlight color (direction of the line is the > same than the lines in kicker, system tray, ... > > normal task > ----------- > no line no color at all no indicator. breeze mean no additional unusefull > information and space for the elements to breath > > hover task > ---------- > blue Highlight color line like focus task with additional Highlight color > background and 24% opacity > > attention task > -------------- > had a 3px height line in NeutralText color (old one didn't use colorscheme > here) > > minimzed task > ------------- > rectangular element with Text color and 0.16% opacity (you can see it now in > breeze and breeze-dark color scheme) > > I know it's to late for kf5.26 (03.09) but however if you think it should be > available with plasma 5.8 LTS let me know. > > > Diffs > ----- > > src/desktoptheme/breeze/widgets/tasks.svgz 15a5921 > > Diff: https://git.reviewboard.kde.org/r/128802/diff/ > > > Testing > ------- > > the stylesheed stuff were checked with different color schemes and with kate > in the svg "source code". > > > File Attachments > ---------------- > > the tasks.svgz file for your tests please copy it to your plasma theme > dictionary > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz > preview of the different tasks (inkscape file preview) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png > Breeze Preview > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png > Breeze Dark Color Scheme > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png > Arch Color Scheme > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png > Oxygen Color Scheme > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png > Honeycomb color scheme > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png > update tasks file with suggestions from kai > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/5ba391cd-6bbc-43df-ab51-fcab9cbf964c__tasks.svgz > Breeze Color Scheme with updated tasks.svgz file > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/202f150a-1011-4ca9-acfc-1811af24ae79__Screenshot_20160830_155736.png > Breeze Dark Color Scheme with updated tasks.svgz file > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/88a6cb0d-571d-43e9-9901-8e55ac238073__Screenshot_20160830_155802.png > Honeycomb Color Scheme with updated tasks.svgz file > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/f3be8584-bfb3-42e4-b687-87309615a9dd__Screenshot_20160830_155820.png > now with ButtonHover for hover task > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/c068c5ab-341f-4c31-a94b-a737befa058b__tasks.svgz > > > Thanks, > > Andreas Kainz > >
