----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128819/#review98861 -----------------------------------------------------------
good direction, commenting on some QML code style issues kcmkwin/kwindecoration/qml/Previews.qml (line 29) <https://git.reviewboard.kde.org/r/128819/#comment66553> remove whitespace kcmkwin/kwindecoration/qml/Previews.qml (line 31) <https://git.reviewboard.kde.org/r/128819/#comment66555> don't call it listView if it's not a ListView anymore kcmkwin/kwindecoration/qml/Previews.qml (line 42) <https://git.reviewboard.kde.org/r/128819/#comment66554> width and height shouldn't be needed at all in the highlight element kcmkwin/kwindecoration/qml/Previews.qml (line 51) <https://git.reviewboard.kde.org/r/128819/#comment66556> this may lead to things lookng blurry as not being aligned to pixel grid anymore. the delegate itself should be as big as cellWidth/height then the contents inside may have a margin. for instance using units.smallSpacing kcmkwin/kwindecoration/qml/Previews.qml (line 110) <https://git.reviewboard.kde.org/r/128819/#comment66557> wrong indentation - Marco Martin On Sept. 3, 2016, 2:55 p.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128819/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2016, 2:55 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > change the list layout to a grid layout and move the config button to the > preview. > > > Diffs > ----- > > kcmkwin/kwindecoration/qml/Previews.qml a146f86 > > Diff: https://git.reviewboard.kde.org/r/128819/diff/ > > > Testing > ------- > > qml file was tested on my system. > > > this is my first qml patch so be careful. > > > File Attachments > ---------------- > > window decoration kcm update > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png > > > Thanks, > > Andreas Kainz > >
