> On Sept. 11, 2016, 8:50 nachm., David Edmundson wrote: > > src/declarativeimports/plasmastyle/ToolButtonStyle.qml, line 119 > > <https://git.reviewboard.kde.org/r/128870/diff/1/?file=476618#file476618line119> > > > > shouldn't both be colorscoped?
That's what Button and ComboBox do, ie. ButtonColorGroup if the background is visible - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128870/#review99114 ----------------------------------------------------------- On Sept. 9, 2016, 9:41 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128870/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 9:41 vorm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This fixes the size of the icon as well as its color group. > > > Diffs > ----- > > src/declarativeimports/plasmastyle/ToolButtonStyle.qml 2518656 > > Diff: https://git.reviewboard.kde.org/r/128870/diff/ > > > Testing > ------- > > It is no longer squashed and ugly and its color is correct on the lock screen > now (white like the text) > > > File Attachments > ---------------- > > Fixed > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/9d02ec39-2cb2-4c18-8088-aa86973daab4__Screenshot_20160909_113913.png > > > Thanks, > > Kai Uwe Broulik > >
