mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > main.qml:36 > > - Layout.minimumWidth: horizontal ? plasmoid.configuration.length : 1 > - Layout.maximumWidth: (plasmoid.configuration.expanding || !horizontal) ? > Infinity : plasmoid.configuration.length > - > - Layout.minimumHeight: horizontal ? 1 : plasmoid.configuration.length > - Layout.maximumHeight: (plasmoid.configuration.expanding || horizontal) ? > Infinity : plasmoid.configuration.length > + Layout.preferredWidth: horizontal ? plasmoid.configuration.length : 0 > + Layout.preferredHeight: horizontal ? 0 : plasmoid.configuration.length some time ago on old qt releases i noticed that the layouts ignored items with one of the sizes as 0 (even height for an horizontal one) does it work now? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2785 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
