> On Sept. 15, 2016, 12:34 p.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 137
> > <https://git.reviewboard.kde.org/r/128915/diff/1/?file=476912#file476912line137>
> >
> >     does it render this redundant?

Otherwise it could make sense to statically have an `anchors.fill: parent`.


> On Sept. 15, 2016, 12:34 p.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 140
> > <https://git.reviewboard.kde.org/r/128915/diff/1/?file=476912#file476912line140>
> >
> >     this if isn't very useful now.
> >     If it was null, we'd have crashed already.

Good catch. In fact this should also get outside the initial if altogether. If 
graphicObject is nullptr it still should be set.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99195
-----------------------------------------------------------


On Sept. 15, 2016, 11:20 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Reply via email to