This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 22, 2016, 8:34 p.m.)


This change has been discarded.

Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić.

Bugs: 320995

Repository: kdeplasma-addons


The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but never 
set anything valid to it and therefore has no drop shadow.
This patch add the shadow when using a qt style that is aware of the KDE shadow 
hint in the widget's property. I haven't found a documentation for this 
property but it seems that they are recognized by oxygen and are also copied to 
qtcurve (and probably bespin, haven't checked).
A better solution might be using the plasma shadow although I don't know how to 
do that without copying the code to install shadows from kdelibs, unless 
someone adds a new api to apply plasma themed shadows to a window.


  applets/lancelot/application/LancelotWindow.cpp c66c565 

Diff: https://git.reviewboard.kde.org/r/114424/diff/


Have shadow with both oxygen and qtcurve.


Yichao Yu

Reply via email to