----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129005/#review99489 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On set. 23, 2016, 8:19 p.m., Rex Dieter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129005/ > ----------------------------------------------------------- > > (Updated set. 23, 2016, 8:19 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: discover > > > Description > ------- > > Kirigami is not really a required build-time component, so mark it as runtime > instead. > > > Diffs > ----- > > CMakeLists.txt 2756fb1 > > Diff: https://git.reviewboard.kde.org/r/129005/diff/ > > > Testing > ------- > > build succeeds, cmake output now includes: > > -- The following RUNTIME packages have been found: > > * KF5Kirigami (required version >= 1.0) , KDE’s lightweight user interface > framework for mobile and convergent applications , > <https://techbase.kde.org/Kirigami> > Required by discover qml components > > > Thanks, > > Rex Dieter > >