> On Sept. 29, 2016, 8:25 a.m., Marco Martin wrote: > > are you sure they are completely interchangeable? (would have to have an > > ifdef otherwise)
they're not completely intechangable normally, but for this particular case it seems fine. I've just filled in the Testing Done propery. This runnable takes a copy of the pointers to some GL textures that should be deleted. the WindowThumbnail object then throws away its knowledge of those textures and at some point creates new ones. When the actual deletion of the old ones happens shouldn't affect WindowThumbnail at all. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review99654 ----------------------------------------------------------- On Sept. 28, 2016, 9:58 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129065/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:58 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid > in earlier Qt. > > This shouldn't have any behavioural effect. > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp > 0453c092f7a7144f04fdacc81b031e8c352fa23b > > Diff: https://git.reviewboard.kde.org/r/129065/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
