----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 -----------------------------------------------------------
Instead of using fcitx-, would it be possible to make generic icons per language code so they can also be used by kimpanel (which in turn can use fcitx or ibus or scim)? Do you really need different icons for each IME engine instead of just per language? Having icons for specific fcitx plugins upstream seems like bad layering. - Eike Hein On Oct. 3, 2016, 6:18 p.m., Yunhe Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 6:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > ----- > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > src/desktoptheme/breeze/icons/input.svgz > ef7ba12c12427d2171ad31ebe5886c9665e4cdf0 > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
