graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Klipper shows a notification when the shortcuts next/prev history item gets triggered. This notification used to be implemented in the class KlipperTray. With the switch from SNI based clipper to a Plasmoid the notification got lost as the Plasmoid doesn't use the KlipperTray class at all. This change moves the notification handling from KlipperTray to Klipper so that it gets emitted for both SNI and Plasmoid based klipper. BUG: 368808 FIXED-IN: 5.8.1 TEST PLAN Set the shortcuts, triggered them and verified the notification gets shown. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH klipper-notification-5.8 REVISION DETAIL https://phabricator.kde.org/D2942 AFFECTED FILES klipper/CMakeLists.txt klipper/klipper.cpp klipper/klipper.h klipper/tray.cpp klipper/tray.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas