This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 17, 2016, 7:35 a.m.)

Review request for Plasma.


Drop changing the Qt Requirement for the framework, applied an extended patch 
based on another review

Repository: plasma-framework


Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.

Diffs (updated)

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/plasmaquick/dialog.cpp eac9ee5 
  src/plasmaquick/dialogshadows.cpp eb67926 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 


Alberto Curro

Reply via email to