-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129103/#review100089
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Oct. 4, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129103/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> In plasma-framework internally we use a QJsonObject for reading the metadata. 
> Providing the metadata in desktop only makes the system have to parse 
> metadata.desktop and then convert it internally into a QJsonObject. 
> Furthermore, to do so we use a desktop file parser that is not very 
> performant (at least in comparison to KConfig's).
> 
> As part of #129102, we made sure that plasma supports `metadata.json`. This 
> patch leverages it moving the weight of converting desktop to json at compile 
> time.
> 
> It could even make sense to convert to binary json as well, I wonder whether 
> that would improve at all.
> 
> 
> Diffs
> -----
> 
>   KF5PackageMacros.cmake 335fc81 
> 
> Diff: https://git.reviewboard.kde.org/r/129103/diff/
> 
> 
> Testing
> -------
> 
> Ran RR 129102 without any metdata.desktop files on my system.
> 
> Nope, hold the ship its, still needs work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Reply via email to