> On Oct. 17, 2016, 4:07 p.m., David Edmundson wrote:
> > Though in future, I wouldn't bother putting a logging category on an 
> > autotest.

that was done because the aytotest statically links to a model from imports, so 
it needs it in order to still link correctly


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129210/#review100103
-----------------------------------------------------------


On Oct. 17, 2016, 3:28 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129210/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 3:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> mostly janitorial patch: port every terminal output to appropriate 
> QCdebug/QCwarning, each different binary has its own logging category now, so 
> it's possible to enable/disable them selectively.
> this should also make plasmashell a bit more quiet on terminal by default
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt d6ed24d 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/calendar/CMakeLists.txt 93d9c14 
>   src/declarativeimports/calendar/calendar.cpp 790833b 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp bcc6177 
>   src/declarativeimports/core/CMakeLists.txt 689a4b6 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
>   src/declarativeimports/core/datasource.cpp f60e2cc 
>   src/declarativeimports/core/framesvgitem.cpp bc8d45a6 
>   src/declarativeimports/core/iconitem.cpp 8f29ee2 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/declarativeimports/plasmacomponents/CMakeLists.txt 8e5ca90 
>   src/declarativeimports/plasmacomponents/fullscreenwindow.cpp 05da708 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 83016c2 
>   src/declarativeimports/plasmacomponents/qmenu.cpp c6b59a8 
>   src/declarativeimports/platformcomponents/CMakeLists.txt 4cce385 
>   src/declarativeimports/platformcomponents/application.cpp 1326a7b 
>   src/plasmapkg/CMakeLists.txt 7d3df5d 
>   src/plasmapkg/plasmapkg.cpp 3724ae8 
>   src/plasmaquick/CMakeLists.txt 8aaa77a 
>   src/plasmaquick/configmodel.cpp 03beac7 
>   src/plasmaquick/configview.cpp e8627c9 
>   src/plasmaquick/containmentview.cpp 309a2cb 
>   src/plasmaquick/dialog.cpp 9afdf60 
>   src/plasmaquick/dialogshadows.cpp 10b5ed9 
>   src/plasmaquick/packageurlinterceptor.cpp 4aa5c3a 
>   src/plasmaquick/view.cpp ca6ae6f 
>   src/scriptengines/qml/CMakeLists.txt fd953d6 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp d0dbda9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129210/diff/
> 
> 
> Testing
> -------
> 
> builds, still works
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Reply via email to