> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53 > > <https://git.reviewboard.kde.org/r/129308/diff/1/?file=483828#file483828line53> > > > > This original code is trying to make sure we only reset once instead of > > twice as one will be wasteful. > > > > Wouldn't changing it to if (isExpanded) work correctly too? > > Miklós Máté wrote: > I don't know how expensive it is to reset the selection, but sure, using > "if (isExpanded)" works too.
not very expensive. Lets ship this. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129308/#review100502 ----------------------------------------------------------- On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129308/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 12:30 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > When opening the calendar popup of the digital clock plasmoid, the selection > is on the day the popup was last opened -- possibly days or weeks ago. This > patch fixes that. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da > > Diff: https://git.reviewboard.kde.org/r/129308/diff/ > > > Testing > ------- > > > Thanks, > > Miklós Máté > >
