graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY The glide effect tried to not animate any window the SlidingPopups effect animates. But it detected that in a very crude way. It announced the KDE_SLIDE atom and checked for windows having that property set. This has a few disadvantages: - KWindowEffects::isEffectAvailable gets confused as an effect announces support for SlidingPopups which doesn't provide SlidingPopups - The approach can only work for X11 windows - The approach causes X11 usage in the ctor With this change the GlideEffect implements a slot for EffectsHandler::windowDataChanged to detect that the SlidingPopupsEffect grabbed the window. The X11 atom interaction is removed. REPOSITORY rKWIN KWin BRANCH glide-no-atom REVISION DETAIL https://phabricator.kde.org/D3296 AFFECTED FILES effects/glide/glide.cpp effects/glide/glide.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas