----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: kpackage Description ------- locateAll can return nothing, therefore we can't always call .last() on it. Existing code should be able to handle an empty package root as the user could also also have provided a broken package root as an argument. Diffs ----- src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db Diff: https://git.reviewboard.kde.org/r/129400/diff/ Testing ------- Ran kpackagetool --generate-index -g Previously asserted. No longer asserted. Thanks, David Edmundson
