----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129615/ -----------------------------------------------------------
Review request for Plasma and Yichao Yu. Repository: qtcurve Description ------- QtCurve defines a certain number of specific XCB client messages that are sent under certain conditions. As far as I can tell these are destined to GTk2 applications using the QtCurve theme, but they are sent regardless of the nature of the client (so also to Qt-based applications). Qt4 doesn't seem to mind, but Qt5 tends to print a warning whenever an unknown/unsupported client message is received, which is not very elegant. I've been using the attached patch for a while now that suppresses these error messages by not sending the XCB client messages that Qt5 complained to me about. Curiously this never happened for messages related to menu- and statusbar toggling. I don't notice any regressions, but I have only tested this on KDE desktops. I'm CC'ing the Plasma group in hope someone there may have suggestions for a more elegant fix. Diffs ----- lib/utils/x11utils.cpp 40339e3 qt4/kwin/qtcurveclient.cpp 80855cf qt5/kwin/qtcurveclient.cpp d784bd4 Diff: https://git.reviewboard.kde.org/r/129615/diff/ Testing ------- On Kubuntu 14.04 under Plasma4 with KF5 applications installed in /opt/local . Thanks, René J.V. Bertin
