mart added inline comments.

INLINE COMMENTS

> mart wrote in shellcorona.cpp:1922
> i could just remove that disconnect, the thing is, i'm always hesitant to 
> change things in ways that may have had a reason.
> that disconenct was added somewhere back in 2014, i can test removing it if 
> it still has a reason

apparently if it's managed just by the signal it seems to be too "late", as the 
containments don't seem to be cleaned in a single startup from the config file 
and i sometimes get crashes when i change activity

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3981

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, andreaska, sebas

Reply via email to