The minutes...
--
sebas
http://www.kde.org | http://vizZzion.org
Plasma Meeting minutes 09-01-2017
Present: kbroulik, notmart, Sho_, Riddell, bshah, romangg, sebas
PSA by Kai: https://notes.kde.org/p/plasma_5_9 release announcement draft for
Plasma 5.9, we need some more text about new NM KCM, wayland stuff, and the
look and feel export stuff. I already wrote a bunch of text but needs a bit
more pls <3
kbroulik:
* Worked on global menu support, d_ed spotted a showstopper, probably won't
make it for 5.9 :(
* Merged audio playback indicator in task manager
* Icon item supports non-square icons now, for FolderView thumbnails
* Various fixes and improvements here and there
notmart:
* landed l&f kwin decoration export/import: https://phabricator.kde.org/D3832
https://phabricator.kde.org/D3833
Diff 3832 "import kwin deco and button order in l&f" [Closed]
https://phabricator.kde.org/D3832
Diff 3833 "export kwin theme to l&f" [Closed] https://phabricator.kde.org/D3833
* KNewstuff bug: translate type names in the wrapper plasmapkg2 became to
maintain compatibility with old knsrc files
* another multiscreen problem https://phabricator.kde.org/D3981 needs review
asap, needs to be in the beta
Diff 3981 "better clean up of duplicate containments" [Needs Review]
https://phabricator.kde.org/D3981
* Kirigami:
** better back button behavior on desktop systems
** video for kirigami 2.0 https://www.youtube.com/watch?v=BxRw9YPTxTE
https://www.youtube.com/watch?v=Zqm5Xen_Hhs
** kirigami2 beta2 release
* planning to put a made by kde thing in the splash if people are ok with it
Sho:
* [Launchers] Fixed regression causing "All Applications" in "Application
Dashboard" to be empty
* [Launchers] Fixed regression on master causing empty favorites
* [TM/Launchers] New "Pin" lingo for "Add as Launcher / Show a launcher"
* [FV] Made Return/Enter run all selected items instead of just the current
item, a la Dolphin
* [FV] Fixed Enter/Return not running non-dir items in list view mode
* [FV] Fixed rubber band selection not updating current index
* [FV] Fixed regression causing preview popups to close once the mouse enters
them
* [TM] Finally/hopefully fixed the "Pinned Chrome disappears when all Chrome
windows are closed" bug
* [TM] Dealing with user feedback on text label collapse behavior in task
buttons, asking for a new round of feedback after providing some explanations
* [Pager] Clean up drag state when exiting the applet during a drag and
releasing it outside the applet
* [General] Tons of code reviews for TM, FV, etc. - TM tooltip redesign, TM
audio indicators, FV list view back button, going through iterations with
authors
* [General] General pestering of people about uncommitted patches, unattended
tickets, etc. for 5.9
Riddell:
-plasma 5.9 beta is this week, add anything you want in the announce to the
notes page pronto as I'll be writing that up today
https://notes.kde.org/p/plasma_5_9
-add any features you want to 5.9 pronto, freeze is on thursday midday GMT
-should we release plymouth-kcm with 5.9?
-FOSDEM is looking light on people, sign up now to get in the party
https://community.kde.org/Promo/Events/FOSDEM/2017
-What should we demo at FOSDEM?
-Has anyone tested the Neon docker images?
http://jriddell.org/2017/01/06/kde-neon-now-available-on-docker/ an easy way to
set up and test Plasma builds or take screenshots or develop
bshah:
- whole week wasted fixing this : https://phabricator.kde.org/T4955
Task 4955 "[bullhead] Permissions for android device nodes are wrong inside
container" [Resolved,Normal] {Plasma: Mobile} https://phabricator.kde.org/T4955
- I just fixed https://phabricator.kde.org/T4941 (Task 4941 "[bullhead]
Autostart lxc container in android userspace" [Open,Normal] {Plasma: Mobile}
https://phabricator.kde.org/T4941 )
romangg:
Committed:
D3630 - Diff 3630 "[Digital Clock] Bug fixes and ui code optimization" [Closed]
https://phabricator.kde.org/D3630
D3738 - Diff 3738 "[Task Manager] Tooltips redesign" [Closed]
https://phabricator.kde.org/D3738
D4027 - Diff 4027 "[libinput] Fix Connection DBus object creation in thread"
[Closed] https://phabricator.kde.org/D4027
under review:
D4026 - Diff 4026 "[platforms/drm] Subclass DrmBuffer and fix cleanup after
page flip" [Needs Review] https://phabricator.kde.org/D4026
needs review badly (5.9!!!):
D3617 - Diff 3617 "[Touchpad KCM] New KWin Wayland version" [Needs Review]
https://phabricator.kde.org/D3617
sebas:
* Little Plasma time due to other stuff on the plate
* kscreen has a number of new UI bugs, an enthusiast user filed a whole bunch,
most of them valid, known, not in bugzilla and addressed with the kscreen kcm
redesign
Log:
[12:00:35] <sebas> meeting, however!
[12:00:36] <bshah> pft.. now I want kbshah
[12:00:38] <bshah> :P
[12:00:52] <bshah> oops.. I don't have notes ready
[12:00:56] <Sho_> here
[12:00:57] -*- sebas reads that as keyboardshah
[12:01:04] -*- kbroulik
[12:01:06] <pursuivant> plasma-nm (master) v5.7.95-68-g5dd7de3d * Jan Grulich:
libs/handler.cpp
[12:01:07] <pursuivant> Avoid sending notifications on request scan
[12:01:07] <pursuivant>
https://commits.kde.org/plasma-nm/5dd7de3d64e25ac17e54bf2170bf5f83b5bbdf79
[12:01:13] <kbroulik> kernelshah
[12:01:18] <sebas> bshah: ssht ... everybody quickly writes them when I shout
meeting.
[12:01:23] <sebas> don't tell anybody!
[12:01:36] <romangg> kbroulik: when do you merge D4038?
[12:01:36] <sKreamer> Diff 4038 "[Task Manager] Only match application name if
we never managed to match PID" [Accepted] https://phabricator.kde.org/D4038
[12:02:13] <bshah> though my notes are one liner
[12:02:20] <bshah> I literally did just one thing
[12:02:29] <Riddell> meeting? anyone seen a team meeting?
[12:02:47] <sebas> yes, I saw it squishing by
[12:03:28] <sebas> So, kbroulik, notmart, Sho_, Riddell, bshah, romangg I take
it? (random order more or less)
[12:03:46] <notmart> yes
[12:03:58] <sebas> go go gadgeto broulik then!
[12:03:59] <notmart> and anybody else that wants to participate
[12:04:05] <notmart> d_ed ?
[12:04:15] <kbroulik> * Worked on global menu support, d_ed spotted a
showstopper, probably won't make it for 5.9 :(
[12:04:15] <kbroulik> * Merged audio playback indicator in task manager
[12:04:15] <kbroulik> * Icon item supports non-square icons now, for FolderView
thumbnails
[12:04:15] <kbroulik> * Various fixes and improvements here and there
[12:05:45] <kbroulik> next
[12:05:55] <sebas> notmart!
[12:06:29] <notmart> * landed l&f kwin decoration export/import:
https://phabricator.kde.org/D3832 https://phabricator.kde.org/D3833
[12:06:29] <sKreamer> Diff 3832 "import kwin deco and button order in l&f"
[Closed] https://phabricator.kde.org/D3832
[12:06:29] <sKreamer> Diff 3833 "export kwin theme to l&f" [Closed]
https://phabricator.kde.org/D3833
[12:06:30] <notmart> * KNewstuff bug: translate type names in the wrapper
plasmapkg2 became to maintain compatibility with old knsrc files
[12:06:32] <notmart> * another multiscreen problem
https://phabricator.kde.org/D3981 needs review asap, needs to be in the beta
[12:06:32] <sKreamer> Diff 3981 "better clean up of duplicate containments"
[Needs Review] https://phabricator.kde.org/D3981
[12:06:34] <notmart> * Kirigami:
[12:06:35] <notmart> ** better back button behavior on desktop systems
[12:06:37] <notmart> ** video for kirigami 2.0
https://www.youtube.com/watch?v=BxRw9YPTxTE
https://www.youtube.com/watch?v=Zqm5Xen_Hhs
[12:06:38] <notmart> ** kirigami2 beta2 release
[12:06:45] <notmart> questions or next
[12:06:58] <notmart> ah,a sec
[12:07:22] <notmart> planning to put a made by kde thing in the splash if
people are ok with it
[12:07:25] <kbroulik> oh, forgot, PSA: https://notes.kde.org/p/plasma_5_9
release announcement draft for Plasma 5.9, we need some more text about new NM
KCM, wayland stuff, and the look and feel export stuff. I already wrote a bunch
of text but needs a bit more pls <3
[12:07:47] <notmart> wanted to at least at first to bake the text in a svg, to
have the idea that should *not* be translated
[12:07:49] <Sho_> will any text do or does it have to be about plasma 5.9
[12:07:55] <Sho_> :P
[12:08:00] <sebas> Lorem ipsum...
[12:08:30] <sebas> Erm no, please help with these things, it's important for
users to read, and it promotes our own, hard work
[12:08:57] <sebas> and it's fucking annoying if you're the only person caring
about the promo side, such as writing texts, literally a shame on release day
[12:09:01] --> ltinkl (~ltinkl@2a00:1028:83cc:7d32:3c55:9b5:8de7:42f1) has
joined #plasma
[12:09:13] <notmart> kbroulik: will give a look, should be able to add a
paragraph or so
[12:09:18] -*- jgrulich just added some info about network KCM
[12:09:32] <Riddell> screenshots welcome too
[12:09:51] <-- toscalix (~toscalix@90.170.203.139) has quit (Quit: Konversation
terminated!)
[12:09:53] <llucas> I can take care about screenshots ;p
[12:10:02] <Riddell> ah llucas!
[12:10:03] <-- JimeMC (~j...@253.red-2-136-213.dynamicip.rima-tde.net) has quit
(Ping timeout: 256 seconds)
[12:10:15] <notmart> next?
[12:10:24] <Sho_> that'd be me I think
[12:10:27] <Riddell> go Sho_
[12:10:30] <jgrulich> I'm not really good at writing so feel free to rewrite my
part about network KCM
[12:10:31] <Sho_> It's been a really awesome week for pre-release fixes and UI
polish, including a long-standing libtm thing
[12:10:38] <Sho_> * [Launchers] Fixed regression causing "All Applications" in
"Application Dashboard" to be empty
[12:10:40] <Sho_> * [Launchers] Fixed regression on master causing empty
favorites
[12:10:41] <Sho_> * [TM/Launchers] New "Pin" lingo for "Add as Launcher / Show
a launcher"
[12:10:43] <Sho_> * [FV] Made Return/Enter run all selected items instead of
just the current item, a la Dolphin
[12:10:44] <Sho_> * [FV] Fixed Enter/Return not running non-dir items in list
view mode
[12:10:46] <Sho_> * [FV] Fixed rubber band selection not updating current index
[12:10:47] <Sho_> * [FV] Fixed regression causing preview popups to close once
the mouse enters them
[12:10:49] <Sho_> * [TM] Finally/hopefully fixed the "Pinned Chrome disappears
when all Chrome windows are closed" bug
[12:10:50] <Sho_> * [TM] Dealing with user feedback on text label collapse
behavior in task buttons, asking for a new round of feedback after providing
some explanations
[12:10:52] <Sho_> * [Pager] Clean up drag state when exiting the applet during
a drag and releasing it outside the applet
[12:10:53] <Sho_> * [General] Tons of code reviews for TM, FV, etc. - TM
tooltip redesign, TM audio indicators, FV list view back button, going through
iterations with authors
[12:10:55] <Sho_> * [General] General pestering of people about uncommitted
patches, unattended tickets, etc. for 5.9
[12:11:04] --> toscalix (~toscalix@90.170.203.139) has joined #plasma
[12:11:06] <Sho_> (actually the "hopefully" is old copy, it's definitelt fixed
:P)
[12:11:20] <-- toscalix (~toscalix@90.170.203.139) has quit (Read error:
Connection reset by peer)
[12:11:28] --> toscalix (~toscalix@90.170.203.139) has joined #plasma
[12:11:37] <Sho_> questions || next
[12:12:07] <Riddell> -plasma 5.9 beta is this week, add anything you want in
the announce to the notes page pronto as I'll be writing that up today
https://notes.kde.org/p/plasma_5_9
[12:12:07] <Riddell> -add any features you want to 5.9 pronto, freeze is on
thursday midday GMT
[12:12:07] <Riddell> -should we release plymouth-kcm with 5.9?
[12:12:07] <Riddell> -FOSDEM is looking light on people, sign up now to get in
the party https://community.kde.org/Promo/Events/FOSDEM/2017
[12:12:08] <Riddell> -What should we demo at FOSDEM?
[12:12:10] <Riddell> -Has anyone tested the Neon docker images?
http://jriddell.org/2017/01/06/kde-neon-now-available-on-docker/ an easy way to
set up and test Plasma builds or take screenshots or develop
[12:12:31] <bshah> we should for sure demo Plasma Mobile! \o/ :P
[12:12:47] <bshah> or rather s/we/you/ :\
[12:12:51] <Riddell> bshah: yes please, I'll chat to you about how to set that
up
[12:13:39] <bshah> cool
[12:14:15] <Riddell> so any thoughts on plymouth-kcm? I'm a yes
[12:14:29] <sebas> I tend to yes, too
[12:14:59] <sebas> ow wait .. no I don't
[12:15:04] <sebas> got a link for it?
[12:15:10] <Riddell> kde:plymouth-kcm
[12:15:13] <notmart> did people on other/weird distributuions actually tried it?
[12:15:29] <sebas> I confused it with something else, a new KCM should only be
added if it got really properly reviewed
[12:15:34] <sebas> but really, rather nope
[12:15:42] <Riddell> xhost +
[12:15:42] <Riddell> docker run -v /tmp/.X11-unix:/tmp/.X11-unix -e DISPLAY=:0
kdeneon/plasma:dev-unstable kcmshell5 kcm_plymouth
[12:16:15] <Sho_> no nested wayland? :P
[12:16:21] <Riddell> what do you count as really reviewed?
[12:16:22] <notmart> (/me of course is a yes, but is quite frustrated that new
things get very little test from people other than who develops it until is
released, then the tsunami of bug reports come in)
[12:16:36] <notmart> ok, then let's do it for 5.10
[12:16:39] <notmart> *but*
[12:16:52] <notmart> should be installed by default in neon developer edition
[12:17:02] <notmart> and should get actually tested
[12:17:26] <bshah> so.. should I go ahead?
[12:17:32] <sebas> Riddell: code and ui review, and a very conscious decision
if we want to clutter system settings even more
[12:17:54] <sebas> and preferably done QML only, so it's easy to port in the
future
[12:18:04] <notmart> yep, is qml only ;)
[12:18:15] <-- ejay (~edwin@94.158.225.38) has quit (Quit: Konversation
terminated!)
[12:18:16] <sebas> I'm not fond of adding kcms in system settings current state
of mess
[12:18:37] <sebas> notmart: is there a phab rr with screenshots?
[12:18:55] <sebas> I can have a look and possibly retract my objections before
thursday
[12:19:09] <notmart> no as it wasn't a patch on an existing repo but its own..
[12:19:16] <sebas> ah right
[12:19:32] <sebas> I'm not swimming in time to test things right now though
[12:19:50] <sebas> let's talk about that outside of this meeting though
[12:19:54] <Sho_> could we move on and discuss the kcm further after ... thanks
[12:19:55] <sebas> bshah is next up
[12:19:58] <notmart> sure
[12:20:10] <notmart> (and i'm very ok in postponing it )
[12:20:19] <bshah> okay
[12:20:20] <Riddell> sebas: how to initiate a test? (it was announced 1 days
ago to move)
[12:20:24] <Riddell> 11 days
[12:20:39] <sebas> Riddell: yeah ... my fault for not following it well enough
[12:20:44] <bshah> - whole week wasted fixing this :
https://phabricator.kde.org/T4955
[12:20:44] <sKreamer> Task 4955 "[bullhead] Permissions for android device
nodes are wrong inside container" [Resolved,Normal] {Plasma: Mobile}
https://phabricator.kde.org/T4955
[12:20:51] <bshah> that's all...
[12:20:56] <sebas> I saw complaints about docs on the list and postponed it
myself
[12:21:26] <sebas> bshah: may feel like "waste", but it's actually really
important work, so don't feel bad about it
[12:21:40] <Riddell> sebas: well it has no docs, but since we don't ship
anything that can read the docs anyway it's unclear if they're needed
[12:21:56] <sebas> Feel "I fixed the most boring motherfucking bug and managed
to find a whole lot of patience to do it" :)
[12:21:57] <bshah> yeah well. it was meh that in end it was just single
one-liner
[12:22:25] <sebas> I know the feeling
[12:22:42] <sebas> but it being just a one-liner means that you got *almost*
everything right, which is good
[12:23:14] <bshah> aye
[12:24:45] <sebas> romangg: you're there now?
[12:25:04] <romangg> stuff commited:
[12:25:09] <romangg> D3630
[12:25:09] <sKreamer> Diff 3630 "[Digital Clock] Bug fixes and ui code
optimization" [Closed] https://phabricator.kde.org/D3630
[12:25:14] <romangg> D3738
[12:25:14] <sKreamer> Diff 3738 "[Task Manager] Tooltips redesign" [Closed]
https://phabricator.kde.org/D3738
[12:25:18] <romangg> D4027
[12:25:18] <sKreamer> Diff 4027 "[libinput] Fix Connection DBus object creation
in thread" [Closed] https://phabricator.kde.org/D4027
[12:25:24] <romangg> under review:
[12:25:28] <romangg> D4026
[12:25:28] <sKreamer> Diff 4026 "[platforms/drm] Subclass DrmBuffer and fix
cleanup after page flip" [Needs Review] https://phabricator.kde.org/D4026
[12:25:35] <romangg> needs review badly (5.9!!!):
[12:25:39] <romangg> D3617
[12:25:39] <sKreamer> Diff 3617 "[Touchpad KCM] New KWin Wayland version"
[Needs Review] https://phabricator.kde.org/D3617
[12:25:45] <Sho_> the tooltips are a loooot less painful to use now
[12:26:00] <romangg> so almost good? :P
[12:26:13] <Sho_> this is an opinion from a general tooltip hater
[12:26:18] <Sho_> so it's a big compliment
[12:26:20] <Sho_> :P
[12:26:26] <romangg> haha, thought so. thank you! :D
[12:26:56] <romangg> ok. something else if there aren't questions to this?
[12:27:01] <sebas> romangg: I think mg needs to review that
[12:27:01] <romangg> sebas -> review pls
[12:27:04] <Sho_> romangg: the font sizes thing
[12:27:16] <romangg> Sho_: yes
[12:27:18] <romangg> discussion: When doing digital clock and tooltip redesign
it occured to me, that I don't know how or it's not possible to tighten up the
space between text labels and headings. there are always automatic margins,
that can be wrong in certain situations.
[12:27:34] <bshah> if I may add... I just fixed
https://phabricator.kde.org/T4941
[12:27:34] <sKreamer> Task 4941 "[bullhead] Autostart lxc container in android
userspace" [Open,Normal] {Plasma: Mobile} https://phabricator.kde.org/T4941
[12:27:41] <bshah> \o/
[12:27:56] <llucas> digital clock is kinda bigger than in plasma 5.8
[12:28:26] <bshah> (oops sorry for breaking-in topics)
[12:28:31] <romangg> for example we want the digital clock to fill the whole
height. but with normal labels it doesn't if you don't specify the height
explicitely
[12:28:58] <kbroulik> romangg: "automatic margins", I usually end up setting
height to undefined for plasma labels
[12:29:04] --> aniketh__
(uid171160@gateway/web/irccloud.com/x-idhisvcqshyefhkg) has joined #plasma
[12:29:10] <llucas> If I noticed this others will also, so expect bugs about it
[12:29:25] <llucas> digital clock I mean
[12:29:38] <romangg> llucas: it was wanted to increase the digital clock text
height
[12:30:03] <Riddell> so llucas, are you in a mood to make a promo video this
release?
[12:30:21] <llucas> it depends
[12:30:37] <romangg> could you pls wait a second.
[12:30:51] <llucas> ok
[12:31:43] <romangg> example regarding the discussion topic: using header
levels for the tooltips wasn't nice. the text got tiny because of the margins.
[12:32:34] <romangg> you would've needed to increse the overall height
massively to get the same text height than without headers
[12:32:54] <Sho_> because of that there's now a regular label in there with a
font size of "0.6", which i flagged in review because magnic numbers ==
inconsistency
[12:33:31] <-- jgrulich (~jgrulich@217.170.98.36) has quit (Quit: Konversation
terminated!)
[12:33:41] --> jgrulich (~jgrulich@217.170.98.36) has joined #plasma
[12:33:46] <sebas> 0.6 is consistent though for a magic number :)
[12:33:57] <romangg> yea. 60%. ;) is there another solution to the problem?
[12:34:01] <Sho_> not if some other applet picks 0.7 :)
[12:34:35] <sebas> my point is that we use .6 consistently right now, not sure
if adding a property in theme or units for that is really something we want or
should do
[12:34:56] <llucas> romangg have you tested how digital clock behaves in
vertical panel?
[12:35:26] <Sho_> well i mean that's like saying instead of shortDuration we
"use 120 consistently"
[12:35:41] <notmart> problem is if we do a theme unit, there will soon be many
other "special" cases which won't use it because "we are special, we need a
different one"
[12:35:41] <Sho_> i wonder if we need more font sizes in units
[12:36:04] <sebas> Sho_: I get it, just the tradeoff is still the same
[12:36:18] <notmart> and, if there are too many font sizes in units, defeats
the whole point of trying to acheve consistency
[12:36:25] <sebas> Sho_: we have font sizes in PlasmaExtras.Heading
[12:36:53] <Sho_> yep so i said "please use a heading" in review
[12:36:59] <Sho_> but that didn't work out for some reason
[12:37:11] <romangg> notmart: is it a problem of not enough font sizes though
or of automatic margins? (I don't know how it works inside the framework)
[12:37:32] <notmart> automatic margins where?
[12:37:42] <kbroulik> is the meeting over?
[12:37:48] <sebas> Nope, but I would like it to
[12:38:00] <sebas> Should I just finish the meeting, and then we continue the
margins discussion?
[12:38:08] <Sho_> +1
[12:38:12] <romangg> the text itself doesn't stretch completely in height if I
used headings
[12:38:16] <sebas> little relevant to report from my side, anyway:
[12:38:19] <sebas> * Little Plasma time due to other stuff on the plate
[12:38:19] <sebas> * kscreen has a number of new UI bugs, an enthusiast user
filed a whole bunch, most of them valid, known, not in bugzilla and addressed
with the kscreen kcm redesign
[12:38:32] <sebas> Sho_: don't leave before I get a chance to ask you some
things
[12:38:36] <notmart> headings are just labels with an altered font size
[12:38:37] <Sho_> sure
[12:38:56] <notmart> romangg: di you look at the sources for headng looking for
a cause of the bug?
[12:39:13] <romangg> notmart: then the problem is in the labels. in fact this
is true since I had the same problems with the digital clock.
[12:39:27] <kbroulik> height: Math.round(paintedHeight * 1.2) ← probably this
[12:39:29] <romangg> * and in digital-clock are only labels used
