graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY Xkbcommon does not localize the layout names. We always get the US English variant. KWin so far passed the strings from xkbcommon directly to UI visible parts such as the Plasma OSD. This results in not translated elements in our UI. As I figured out today the translations exist in the domain xkeyboard-config. Passing the strings from xkbcommon through this domain gives us translated layouts. Unfortunately the xkeyboard-config is not installed by default on all distributions. E.g. on ubuntu/neon one needs to install xkb-data-i18n to have the translations available. TEST PLAN Untested as I fail to start Plasma/5.8 KWin on my dev system REPOSITORY R108 KWin BRANCH Plasma-5.8-localized-layout-name-in-osd REVISION DETAIL https://phabricator.kde.org/D4243 AFFECTED FILES keyboard_input.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
