graesslin added inline comments.

INLINE COMMENTS

> submenu.cpp:33
>  {
> -   KWindowSystem::setType(winId(), NET::Menu);
> +    setType(Dialog::Dock);
>  }

why is it changed to Dock? A Dock is not a menu and this could have 
side-effects in how KWin manages the window.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4347

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Reply via email to