albertvaka added inline comments.
INLINE COMMENTS
> NotificationDelegate.qml:36-37
>
> - enabled: true
> - checked: notificationItem.containsMouse
> -
This was there so they highlight on hover. Is it not needed anymore?
> NotificationItem.qml:70
> + action("default")
> + } else {
> + close()
This is not the behaviour that was agreed here [1], we shouldn't close the
notification if there is no action to be performed.
[1] https://phabricator.kde.org/D4215
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, mart, davidedmundson, albertvaka
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
