markg reopened this revision. markg added a comment. This revision is now accepted and ready to land.
So now i'm on the correct revision it seems. I applied the diff locally to see how this change looks. It looks OK (can't test it on a "retina" display), but still quite inconsistent with other tooltips in terms of spacing. It looks out of place compared to the other tooltips. Hover over kickoff, then over a taskbar entry to see the difference. Also, i thing you (re)introduced a text eliding issue. Open for example chrome on this url: https://cgit.kde.org/plasma-desktop.git/plain/applets/taskmanager/package/contents/ui/ToolTipInstance.qml?h=Plasma/5.9 it has a long title (the url is the title in fact). I think there was some text eliding magic before you made your changes. Now the full title is visible. That's fine for relatively short to medium sized titles, but large ones (say 30+ characters) is imho too long to display in the tooltip and should probably be elided. Note: i don't get why this is wrong because i do see "elide: Text.ElideRight" in the code... Second thing, the application title in these tooltips is of a "fatter" or "more black" tone then the one in the other tooltips (again, look at kickoff). Btw. just curious, why can't you re-use the tooltip that kickoff uses (or the tray area, or the clock..) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma:_design, #plasma, hein Cc: markg, broulik, subdiff, hein, plasma-devel, davidedmundson, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
