subdiff accepted this revision.
subdiff added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ListItemBase.qml:123
> +                        roundToIconSize: false
> +                        Layout.preferredWidth: Math.round(slider.height * 
> 0.95)
> +                        Layout.preferredHeight: Layout.preferredWidth

Why still the 0.95? Couldn't you just use the slider height? It's still a 
little bit small for the microphone icon (especially showing the red line above 
as the difference between muted and unmuted)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-indicator-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4837

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Reply via email to