hein added a comment.
More review talk: [05:34] <ivan|home> Sho_: I'm unable to reproduce the issue. Can you open the kastats test application while you are testing to see where the issue is? [05:35] <Sho_> I'll have to do that tomorrow, it's pretty late now [05:35] <ivan|home> ok, no hurry. I'm mostly at the faculty wed-fri [05:36] <Sho_> ivan|home: it's possible my kactivities-stats was outdated earlier btw [05:36] <Sho_> i might not have had https://phabricator.kde.org/R159:168c4be89fa96bb3dbb08f71a5f14b696fbfe364 [05:37] <-- leszek (~les...@p2003005b443f3d00022314fffeaf6410.dip0.t-ipconnect.de) has left this server (Quit: WeeChat 1.0.1). [05:37] <Sho_> ivan|home: where is the kastats test app now? [05:38] <ivan|home> kastats - test/model [05:38] <ivan|home> ./tests/model/KActivitiesStatsTestApp [05:38] <Sho_> it crashed when i clicked the refresh button on the logs page btw [05:41] <Sho_> ivan|home: I can't reproduce the issue anymore [05:42] <Sho_> ivan|home: i'm still not sure but i may still be seeing problems with drag reordering, sometimes i can't drag favorites very far to the end of the respective lists (in appdash or kicker) [05:43] <Sho_> maybe it's not allowed to drag all-activities favs past per-activity favs or somet logic like that? [05:43] <Sho_> i feel like the order should be fully customizable in each activity [05:44] <Sho_> (but i can imagine what nightmarish code that means) [05:45] <Sho_> also, is order supposed to be synced globally within the activity or unique to every menu? [05:48] <ivan|home> i'll look into reordering this weekend, it should be fully orderable, but I think I missed on important thing :) REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
