graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed.
I think part of your analysis is wrong. At least I cannot remember that I did the deferring for that reason. I think the call is deferred to get the correct areas repainted in the compositor. If we get a repaint from the decoration it does not include the shadow. So when we are in the compositor pass and render the shadow directly we might not have the shadow area in the to be rendered quads at all. It might be clipped away. That's in my opinion why it used a deferred call to ensure that another compositor repaint is triggered from the setShadow call. REVISION DETAIL https://phabricator.kde.org/D4990 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
