fvogt created this revision. Restricted Application added a project: Plasma.
REVISION SUMMARY The show password button only makes sense with a virtual keyboard on touchscreens. On desktop PCs it's not only not useful, but it can also be used to show (partially) typed in passwords. It also makes it possible to display clipboard entries in plaintext, which is why the clipboard is cleared when the screen locks. By adding a configuration option, the user can decide whether the show password functionality is useful to him. The default is set to show the button to now change the default behaviour. Once the clipboard issue is fixed properly in all cases, the configuration option can be reevaluated, but currently it is in my opinion the best way to fix both issues at once. TEST PLAN Ran kscreenlocker_greet --testing with and without the option changed in the kcm. Worked as expected. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D5227 AFFECTED FILES greeter/greeterapp.cpp kcfg/kscreenlockersettings.kcfg kcm/kcm.ui To: fvogt, #plasma, graesslin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol