anthonyfieroni added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.h:64-67
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)
> +    QString selectedMimeTypeFilter() const Q_DECL_OVERRIDE;
> +    void selectMimeTypeFilter(const QString &filter) Q_DECL_OVERRIDE;
> +#endif

Better overrites them, then ifdef in implementation

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5446

To: elvisangelaccio, #plasma, dfaure
Cc: anthonyfieroni, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to