davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:8
> +
> +

you need to set the translation domain (copy and paste the line from another 
CMakeLists)

> nextcloudjob.cpp:82
> +
> +void NextcloudJob::checkTargetFile(const int suffix, const QUrl& local, 
> KJob* j)
> +{

Replace this first argument with KIO::suggestName(); you just need to know the 
name of the last one you tried; which you can extract from the URL you're using

Then you can kill: createTargetUrl

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D5464

To: yuenlim, #plasma, apol
Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to