hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  looks good !

INLINE COMMENTS

> breezeshadowhelper.h:187
>          //* The Wayland shadow manager to create Shadows for Surfaces 
> (QWindow)
> -        KWayland::Client::ShadowManager* _shadowManager;
> +        QPointer<KWayland::Client::ShadowManager> _shadowManager;
>  

Just to make sure (I haven't read the other review request): this change is 
because Registry now returns QPointer and not raw pointers ? Correct ?

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Reply via email to