fvogt created this revision. Restricted Application added a project: Plasma.
REVISION SUMMARY The browser has them in the cache already, so we avoid loading it ourselves, also we might not even have access to the icons from our context. Some browsers (Opera does) set the favIconUrl of the tab to the base64 data already, which is convenient. The base64 URL gets decoded in the krunner plugin and if it fails or is not available, the browser icon is shown. If the tab is audible or incognito, that icon is preferred. TEST PLAN Installed in Opera 40, Vivaldi 1.91 and Firefox 52, favicons appear in krunner. REPOSITORY R856 Plasma Browser Integration BRANCH favicons (branched from master) REVISION DETAIL https://phabricator.kde.org/D6717 AFFECTED FILES extension/extension.js extension/manifest.json tabsrunner/tabsrunner.cpp To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas