> On July 31, 2017, 3:59 a.m., Anthony Fieroni wrote: > > Modules/about-distro/src/Module.cpp, line 198 > > <https://git.reviewboard.kde.org/r/130208/diff/1/?file=498299#file498299line198> > > > > Plasma now depends on minimum 5.30, you can remove this check. Plasma > > team now use Phabricator and i don't know if David and Marco still read > > reviewboard.
implemented in https://phabricator.kde.org/D7087 - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/#review103510 ----------------------------------------------------------- On July 31, 2017, 7:44 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130208/ > ----------------------------------------------------------- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description > ------- > > Add a new menu with a "Copy to Clipboard" action to the About System module. > See screenshot. The action can be used to conveniently copy information when > reporting a bug etc. > > Example of how the copied text looks like: > > KDE Frameworks Version: 5.37.0 > Qt Version: 5.9.0 > Distro: openSUSE Tumbleweed 20170407 > Kernel: 4.10.8-1-default > OS Type: 64 bit > Processors: 4 × Intel® Core™ i3 CPU M 370 @ 2.40GHz > Memory: 7,7 GiB of RAM > > > Diffs > ----- > > Modules/about-distro/src/Module.h 55337b0e057fda97019291ba1dda1a5c330bb05a > Modules/about-distro/src/Module.cpp > 1852376f96f1f6f4b1cbfdea446270000f84f401 > Modules/about-distro/src/Module.ui 7aff8c4b9162ee04240d0b77f3b1ec9757420322 > > Diff: https://git.reviewboard.kde.org/r/130208/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > About System with the new menu > > https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/13bd0d7a-7a6a-4b48-90ba-4a6dffccd2ac__about-system-1.png > About system with the new menu opened > > https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/9a79cbb6-0c50-4d4d-b24c-48e534aa9086__about-system-menu-open.png > > > Thanks, > > Gregor Mi > >
