broulik added inline comments. INLINE COMMENTS
> devicelisting.cpp:49 > populateListing(); > + setSortingEnabled(true); > } Why disable again? > soldevice.cpp:153 > + const SolDevice * otherDevice = dynamic_cast<const SolDevice*>(&other); > + if (otherDevice != nullptr) > + { Coding style: brace on the same line, also no need for explicit `nullptr` check: if (otherDevice) { REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma Cc: broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas