graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY So far EffectsHandlerImpl directly accessed SceneQPainter::painter through a dynamic cast. If in future the QPainter based compositor should be moved into a plugin we cannot access it through a dynamic cast. To solve this problem the painter method is moved into Scene as a virtual method returning a sane default value. BRANCH scene-qpainter REVISION DETAIL https://phabricator.kde.org/D7214 AFFECTED FILES effects.cpp scene.cpp scene.h scene_qpainter.cpp scene_qpainter.h To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas