progwolff marked 2 inline comments as done. progwolff added inline comments.
INLINE COMMENTS > davidedmundson wrote in Notifications.qml:243 > ? sorry, missed to revert this... > davidedmundson wrote in Notifications.qml:257 > How does this differ to the persistent delegate? > > Can we share most of this? It's almost the same. Only the models differ (NotificationsModel is used in NotificationDelegate, NotificationsHistoryModel is used in NotificationHistoryDelegate). I also thought it might be a good idea to use a seperate delegates here, so that in the future history items might have a different visual representation than persistent notifications. If this is not wanted, we could probably make the model a property of NotificationDelegate. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
