broulik added inline comments. INLINE COMMENTS
> davidedmundson wrote in tasktools.cpp:616 > launcherUrslMatch is in a somewhat hot path that is called a lot. > > If we have to do this, fine, but if there's an alternative; such as resolving > the launcher to a KService (KService::serviceByMenuId) once in the launcher, > that would be IMHO much much better. > > --- > > Also menuId is built from the filename; (vfolder_menu.cpp:947) (prefix in > that line is empty for anything non-supersuper-legacy) > > Is there a reason we can't just compare filenames here? > resolving the launcher to a KService (KService::serviceByMenuId) once in the > launcher, ? > Is there a reason we can't just compare filenames here? Don't know, I just looked at what the rest of the code dealing with `applications:` URLs does. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8258 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
