graesslin added a comment.
In https://phabricator.kde.org/D8398#157766, @subdiff wrote: > Nice! > > You are using AMS on your testing machine I assume? Yes. I'm using defaults :-) > The mode change should currently not work in legacy mode, because `m_modesetRequested` gets only used by AMS. Without AMS you need to call directly `setModeLegacy` with a black buffer. Or maybe just test on `m_modesetRequested` in `presentLegacy` on the next present. This said is there the possibility that the next present won't come soon (also relevant for AMS, where the mode gets changed with the next present)? Yeah, I already got from the code that my change won't work with legacy. And I'm tempted to just not implement it there. At least we could consider to not implement it and wait for a bug report. If we don't get one we could drop the complete legacy mode settings in ~1 year. That's the xorg style of deprecation: known breakage, waiting for someone notices. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8398 To: graesslin, #kwin, #plasma, subdiff, sebas Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
