mlaurent added inline comments.

INLINE COMMENTS

> broulik wrote in foldermodel.h:256
> Did you check whether QML can cope with `const &`? The `urls` is used in an 
> `onMove` QML handler (I recall it not handling `const *` well)

I didn't see an error here, but perhaps I didn't test action which use this 
signal.
To be safe I will exclude this part of patch until I am sure that it's ok.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to